php8: the PHP8 compilation options are only saved if PHP8 is also built

[feckert]

📦 Package Details

Maintainer: @neheb @danielfdickinson

Description:
Even if PHP8 has not been selected for building, the default PHP compile option is stored in '.config'.

# CONFIG_PACKAGE_php8 is not set
CONFIG_PHP8_LIBXML=y
CONFIG_PHP8_DOM=y
CONFIG_PHP8_GETTEXT=y
CONFIG_PHP8_INTL=y
# CONFIG_PHP8_FULLICUDATA is not set
# end of PHP8

That's not what I would expect. Therefore, a dependency is added that checks whether the php8 package has also been selected for building. With this change, the PHP8 compile options are only saved if they have also been selected for building. Additional, the whole thing was also moved to a 'Config.in' file to improve clarity.

This change requires the zabbix-server-frontend to be adjusted as well. Otherwise, I get the following output when calling make menuconf.

tmp/.config-package.in:33478:error: recursive dependency detected!
tmp/.config-package.in:33478:   symbol PACKAGE_php8 is selected by PACKAGE_zabbix-server-frontend
tmp/.config-package.in:1681:    symbol PACKAGE_zabbix-server-frontend depends on PHP8_DOM
tmp/.config-package.in:33502:   symbol PHP8_DOM depends on PACKAGE_php8
For a resolution refer to Documentation/kbuild/kconfig-language.rst

The zabbix-server-frotend can now only be selected if PACKAGE_php8 is enabled for building.

---

🧪 Run Testing Details

• OpenWrt Version: no
• OpenWrt Target/Subtarget: no
• OpenWrt Device: no

---

✅ Formalities

• I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

[Copilot]

Pull request overview

This PR addresses an issue where PHP8 compilation options were being saved to .config even when PHP8 itself was not selected for building. The fix introduces a dependency constraint to ensure PHP8 configuration options are only displayed when the php8 package is selected.

Key changes:

• Moved PHP8 configuration options from inline Makefile definition to a separate Config.in file
• Added depends on PACKAGE_php8 constraint to the configuration menu
• Updated zabbix-server-frontend dependency to prevent recursive dependency issues

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
lang/php8/Makefile	Bumped PKG_RELEASE and replaced inline config with source reference to Config.in
lang/php8/Config.in	New file containing PHP8 configuration options with PACKAGE_php8 dependency constraint
admin/zabbix/Makefile	Bumped PKG_RELEASE and changed php8 dependency syntax to resolve recursive dependency

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[danielfdickinson]

@feckert Thank you for this. LGTM on the Zabbix update.

Note that PHP8 maintainer is @mhei not neheb.

I had forgotten about the Kconfig menu/endmenu construct. That will be useful.

[feckert]

Note that PHP8 maintainer is @mhei not neheb.

Ups you are right.

[mhei]

I also was not aware (anymore) that we can add a depends to a menu, thanks @feckert .
Although I'm not really a fan of pushing the configuration options into "countless" sub-levels, it improves readability and also aligns with other config parts, eg. Perl and Golang, so this is fine with me.
Since this PR conflicts a little bit with #28234 but @danielfdickinson signaled that the changes for zabbix are ok, I will merge this one here as is.
I'll comment on the other PR as well soon.