operatorgroup: ensure clusterroleselectors in clusterrole aggregation rules are sorted#3593
Merged
joelanford merged 1 commit intoJun 9, 2025
Conversation
… rules are sorted Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
fce8174 to
73bb54d
Compare
grokspawn
approved these changes
Jun 9, 2025
Merged
via the queue into
operator-framework:master
with commit Jun 9, 2025
3558fae
13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Ensure that selectors are always in sorted order when generating aggregation rules for operator group cluster roles.
Motivation for the change:
Lack of deterministic order of selectors in aggregation rules causes unnecessary updates of cluster roles, which can cause significant performance issues within the Kubernetes control plane.
Architectural changes:
None
Testing remarks:
Unit tests added to avoid regressions
Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issue