Fix server startup failure when client-ca is empty or not provided#3742
Merged
openshift-merge-bot[bot] merged 1 commit intooperator-framework:masterfrom Jan 21, 2026
Merged
Conversation
Contributor
|
/approve |
grokspawn
approved these changes
Jan 21, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn, rashmigottipati, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
01449fd
into
operator-framework:master
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
This PR fixes a bug in the
pkg/lib/serverpackage where the server fails to start when TLS is enabled but the--client-caflag is empty or not provided.Motivation for the change:
When
--client-cais empty or nil,filemonitor.NewCertPoolStore()attempts to callos.ReadFile("")which fails with an error, causing the server to crash on startup.This issue was discovered during code review of PR #1190 (OPRUN-4416: Remove kube-rbac-proxy from PSM), which would be affected by this bug when PSM is started without a client CA configuration.
Architectural changes:
clientCAEnabled()helper method to check if client CA path is provided and non-emptygetListenAndServeFunc()to conditionally setup client CA monitoring only when a valid path is providedClientCAsandClientAuthwhen client CA is availablecertPoolGetterinterface for type-safe handling of the cert pool storeTesting remarks:
Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issueAssisted-By: Claude-Code