🌱 Bump the k8s-dependencies group to 1.35#3743
Merged
openshift-merge-bot[bot] merged 5 commits intooperator-framework:masterfrom Jan 27, 2026
Merged
🌱 Bump the k8s-dependencies group to 1.35#3743openshift-merge-bot[bot] merged 5 commits intooperator-framework:masterfrom
openshift-merge-bot[bot] merged 5 commits intooperator-framework:masterfrom
Conversation
Bumps the k8s-dependencies group with 4 updates in the / directory: [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver), [k8s.io/kube-aggregator](https://github.com/kubernetes/kube-aggregator), [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) and [sigs.k8s.io/controller-tools](https://github.com/kubernetes-sigs/controller-tools). Updates `k8s.io/apiextensions-apiserver` from 0.34.3 to 0.35.0 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](kubernetes/apiextensions-apiserver@v0.34.3...v0.35.0) Updates `k8s.io/apimachinery` from 0.34.3 to 0.35.0 - [Commits](kubernetes/apimachinery@v0.34.3...v0.35.0) Updates `k8s.io/apiserver` from 0.34.3 to 0.35.0 - [Commits](kubernetes/apiserver@v0.34.3...v0.35.0) Updates `k8s.io/client-go` from 0.34.3 to 0.35.0 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.34.3...v0.35.0) Updates `k8s.io/code-generator` from 0.34.3 to 0.35.0 - [Commits](kubernetes/code-generator@v0.34.3...v0.35.0) Updates `k8s.io/component-base` from 0.34.3 to 0.35.0 - [Commits](kubernetes/component-base@v0.34.3...v0.35.0) Updates `k8s.io/kube-aggregator` from 0.34.3 to 0.35.0 - [Commits](kubernetes/kube-aggregator@v0.34.3...v0.35.0) Updates `sigs.k8s.io/controller-runtime` from 0.22.4 to 0.23.0 - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.22.4...v0.23.0) Updates `sigs.k8s.io/controller-tools` from 0.19.0 to 0.20.0 - [Release notes](https://github.com/kubernetes-sigs/controller-tools/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-tools/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-tools@v0.19.0...v0.20.0) --- updated-dependencies: - dependency-name: k8s.io/apiextensions-apiserver dependency-version: 0.35.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: k8s.io/apimachinery dependency-version: 0.35.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: k8s.io/apiserver dependency-version: 0.35.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: k8s.io/client-go dependency-version: 0.35.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: k8s.io/code-generator dependency-version: 0.35.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: k8s.io/component-base dependency-version: 0.35.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: k8s.io/kube-aggregator dependency-version: 0.35.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: sigs.k8s.io/controller-runtime dependency-version: 0.23.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: sigs.k8s.io/controller-tools dependency-version: 0.20.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
tmshort
force-pushed
the
PR-3741
branch
2 times, most recently
from
b30e1ff to
b8b51e9
Compare
tmshort
changed the title
tmshort
changed the title
oceanc80
reviewed
Jan 27, 2026
| @cd $(BINGO_DIR) && GOWORK=off $(GO) build -mod=mod -modfile=golangci-lint.mod -o=$(GOBIN)/golangci-lint-v1.64.8 "github.com/golangci/golangci-lint/cmd/golangci-lint" | ||
|
|
||
| HELM := $(GOBIN)/helm-v3.19.2 | ||
| HELM := $(GOBIN)/helm-v3.18.3 |
Contributor
Author
There was a problem hiding this comment.
Likely a rebase issue...
Signed-off-by: Todd Short <todd.short@me.com>
Signed-off-by: Todd Short <todd.short@me.com>
Specifically add the following. //nolint:staticcheck // SA1019: NewClientset not available until apply configurations are generated This is the simple solution; otherwise a _lot_ of code would need to be generated via the --with-applyconfig creating the NewClientset functions. Signed-off-by: Todd Short <todd.short@me.com>
Fixes two test failures after K8s 1.35 upgrade: 1. Server-side apply status patch conversion for fake clients 2. WatchListClient feature incompatibility with fake clients causing timeouts The K8s 1.35 upgrade enabled WatchListClient by default, but fake clients don't support WatchList semantics properly. Disable the feature for tests via environment variable and wrap custom ListWatch with compatibility helper. Works around: kubernetes/kubernetes#135895 Signed-off-by: Todd Short <todd.short@me.com> Assisted-By: Claude
anik120
reviewed
Jan 27, 2026
Member
anik120
left a comment
anik120
left a comment
There was a problem hiding this comment.
/lgtm
We should call SA1019 comments as tech debt and address it in a follow up PR though
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oceanc80 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
openshift-merge-bot
Bot
merged commit df41df4
into
operator-framework:master
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #3741
Includes: