Skip to content

OCPBUGS-74389: fix: create separate config client to resolve APIServer TLS update conflicts #3753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Jan 26, 2026
Merged

OCPBUGS-74389: fix: create separate config client to resolve APIServer TLS update conflicts #3753

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions cmd/olm/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,14 @@ func main() {
// create a config that validates we're creating objects with labels
validatingConfig := validatingroundtripper.Wrap(config, mgr.GetScheme())

versionedConfigClient, err := configclientset.NewForConfig(config)
// Create separate config client for operator's proxy syncer to avoid
// SharedInformerFactory conflicts with the APIServer TLS syncer factory.
// The APIServer TLS syncer (in SetupAPIServerTLSConfig) creates its own
// factory, and the operator's proxy syncer creates another factory. Using
// separate client instances prevents watch conflicts between the two factories.
operatorConfigClient, err := configclientset.NewForConfig(config)
if err != nil {
logger.WithError(err).Fatal("error configuring openshift proxy client")
logger.WithError(err).Fatal("error configuring openshift config client for operator")
}
configClient, err := configv1client.NewForConfig(config)
if err != nil {
Expand Down Expand Up @@ -189,7 +194,7 @@ func main() {
olm.WithMetadataClient(metadataClient),
olm.WithOperatorClient(opClient),
olm.WithRestConfig(validatingConfig),
olm.WithConfigClient(versionedConfigClient),
olm.WithConfigClient(operatorConfigClient),
olm.WithProtectedCopiedCSVNamespaces(*protectedCopiedCSVNamespaces),
olm.WithOpenshiftConfigAPIExists(openshiftConfigAPIExists),
)
Expand Down