Skip to content

Inconsistent inline chip heights in text flow#130

Merged
ihordubas99 merged 1 commit intodevfrom
bug/74341-inconsistent-inline-chip-heights-in-text-flow
May 6, 2026
Merged

Inconsistent inline chip heights in text flow#130
ihordubas99 merged 1 commit intodevfrom
bug/74341-inconsistent-inline-chip-heights-in-text-flow

Conversation

@ihordubas99
Copy link
Copy Markdown
Collaborator

Ticket

https://community.openproject.org/projects/communicator-stream/work_packages/74341

What are you trying to accomplish?

Fix inline work package chip causing editor rows to exceed 21px in height.

The InlineChip component inherited the parent editor's line-height (~1.5), which pushed each row to ~23.75px instead of the intended 21px. Additionally, the search dropdown popover lost its internal spacing as a side effect of the fix.

Screenshots

image

What approach did you choose and why?

Set line-height: 1 on InlineChip to prevent it from inheriting the parent editor's line-height. This stops the chip from inflating the row height beyond what the chip's own dimensions require.

To restore spacing in the search dropdown popover (which is rendered as a child of InlineChip and inherits its line-height), added line-height: 1.5 explicitly on SearchContainer.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

Co-authored-by: Copilot <copilot@github.com>
@ihordubas99 ihordubas99 self-assigned this May 4, 2026
@ihordubas99 ihordubas99 requested a review from judithroth May 4, 2026 14:31
Copy link
Copy Markdown
Contributor

@judithroth judithroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nice small solution that you found! 🥳 Code LGTM!
Also, it works as intended:

Image

@ihordubas99 ihordubas99 merged commit 4a2691f into dev May 6, 2026
5 checks passed
@ihordubas99 ihordubas99 deleted the bug/74341-inconsistent-inline-chip-heights-in-text-flow branch May 6, 2026 08:20
@github-actions github-actions Bot locked and limited conversation to collaborators May 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants