feat: simplify size options per acceptance criteria#132
feat: simplify size options per acceptance criteria#132ihordubas99 wants to merge 3 commits intodevfrom
Conversation
Co-authored-by: Copilot <copilot@github.com>
| xxs: { label: "Tiny (inline)", desc: "Identifier" }, | ||
| xs: { label: "Compact (inline)", desc: "Type, Identifier, Subject" }, | ||
| s: { label: "Regular (inline)", desc: "Status, Type, Identifier, Subject" }, | ||
| m: { label: "Compact card", desc: "Compact card - Status, Type, Identifier, Subject" }, |
There was a problem hiding this comment.
Thanks for also removing the duplicate "Compact card" here!
There was a problem hiding this comment.
Please be aware that you updated this to translations in another PR and you need to do the change there as well when you merge.
judithroth
left a comment
judithroth
left a comment
There was a problem hiding this comment.
Ok, this looks good in general! Nice work!
However, there is another PR about translations which is still open I think and which will conflict with the changes here.
Please merge that first, then rebase on current dev (or merge current dev if you prefer that workflow) and ping me again for review.
| s: { label: "Regular", desc: "Status, Type, Identifier, Subject" }, | ||
| m: { label: "Compact card", desc: "Status, Type, Identifier, Subject" }, | ||
| l: { label: "Regular card", desc: "Regular card - Identifier, Subject, Type, Status, Parent, Project" }, | ||
| xl: { label: "Full card", desc: "Full card - Identifier, Subject, Type, Status, Parent, Project, Description" }, |
There was a problem hiding this comment.
We don't show these at the moment, but since it is still there, please also remove the duplicate "Regular card - " and "Full card - " as well.
Be aware of the translations in the other PR for this as well. Please merge that other PR first, then rebase or merge the changes from dev and after that fix the texts.
|
|
||
| const INLINE_SIZE_OPTIONS: InlineWpSize[] = ["xxs", "xs", "s"]; | ||
| const BLOCK_SIZE_OPTIONS: BlockWpSize[] = ["m", "l", "xl"]; | ||
| const BLOCK_SIZE_OPTIONS: BlockWpSize[] = ["m"]; |
2 participants
Ticket
https://community.openproject.org/projects/communicator-stream/work_packages/74651
What are you trying to accomplish?
Simplify the size menu in the work package options popover per acceptance criteria.
Screenshots
What approach did you choose and why?
Changes were minimal - only the
SIZE_METAlabels andBLOCK_SIZE_OPTIONSarray were touched. No logic was changed, only presentation.Merge checklist