Skip to content

Conversation

@Mat001
Copy link
Contributor

@Mat001 Mat001 commented Feb 25, 2021

Summary

  • Fixing unit tests failing on PyPy/PyPy3
  • bumped mmh3 library version to 3.0.0 as that helped eliminate some failures when testing locally

@coveralls
Copy link

coveralls commented Feb 25, 2021

Coverage Status

Coverage remained the same at 95.883% when pulling 8b11e23 on mpirnovar/fix_pypy into 5fefd2b on master.

@aliabbasrizvi
Copy link
Contributor

Seems like a risky change given dropped support for Python 2.7, 3.3, 3.4: https://github.com/hajimes/mmh3/blob/master/README.md

@Mat001
Copy link
Contributor Author

Mat001 commented Feb 26, 2021

Seems like a risky change given dropped support for Python 2.7, 3.3, 3.4: https://github.com/hajimes/mmh3/blob/master/README.md

Good to see you, Ali!
Well, PyPy / PyPy3 unit tests have been failing because of mmh3.
Will not be rushing into breaking stuff for sure. Investigating atm ..

@Mat001 Mat001 changed the title fix: bump mmh3 version to 3.0.0 Fix PyPy unit test failure Feb 27, 2021
@Mat001
Copy link
Contributor Author

Mat001 commented Mar 3, 2021

Addressed in #318 - note that failing dependency installations can be seen when expanding the view in TravisCI log console. A small triangle icon to the left of pip install -r requirements.txt...

Also debating if worth downgrading cryptography lib (which caused filures) because that will cause other py versions tests to fail in the future. MAybe better to make a note in README for pypy/pypy3 to require a diff cryptography version

@Mat001 Mat001 closed this Mar 3, 2021
@Mat001 Mat001 deleted the mpirnovar/fix_pypy branch May 26, 2021 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants