Add ability to highlight full word on partial match#16
Merged
micheleriva merged 4 commits intooramasearch:mainfrom Apr 5, 2025
Merged
Add ability to highlight full word on partial match#16micheleriva merged 4 commits intooramasearch:mainfrom
micheleriva merged 4 commits intooramasearch:mainfrom
Conversation
micheleriva
reviewed
Apr 2, 2025
Contributor
micheleriva
left a comment
micheleriva
left a comment
There was a problem hiding this comment.
Hey @Eveliyse thanks for your PR and sorry for my late review! I left one comment. Can you take a look? Thanks again!
micheleriva
approved these changes
Apr 5, 2025
Contributor
|
Thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am currently using
@orama/oramain a personal project and was looking to use@orama/plugin-match-highlightplugin but noticed that the README for the plugin said that it would be deprecated in favour of this library.I found this library to be alot easier to use than the plugin for generating highlights! However I noticed the ability to highlight full words on partial matches was missing and so I have attempted to add this in.
I'm not especially attached to the way I have approached any of this so please do feel free to ask that I change anything for it to fit any guidelines or internal discussions.