Skip to content

Global edit URL hardcodes master #30

@SamB

Description

@SamB

This seems to be the offending line:

const globalEditURL = repo && `/${repo.owner}/${repo.repo}/edit/master/${repo.path}`

I wouldn't have expected this to be an actual problem, except when I followed the link from microsoft/TypeScript-Website#1320 (comment) I got a 404 page.

Oh! It's a problem in that instance because there really is still a master branch lying around. Perhaps it ought to be renamed v1 ... still, might be a good idea to come up with a way for this plugin to actually link to the correct branch?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions