test: remove t/25-cache-service.t from unstable_tests.txt#7037
Merged
mergify[bot] merged 11 commits intoos-autoinst:masterfrom Feb 27, 2026
Merged
Conversation
okurz
force-pushed
the
fix/024_fix_unstables_part2_cache_service
branch
from
7af3dc1 to
1cce074
Compare
Martchus
requested changes
Feb 24, 2026
okurz
force-pushed
the
fix/024_fix_unstables_part2_cache_service
branch
from
1cce074 to
15e0de7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7037 +/- ##
=======================================
Coverage 99.68% 99.68%
=======================================
Files 417 417
Lines 42913 42927 +14
=======================================
+ Hits 42779 42793 +14
Misses 134 134 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
m-dati
reviewed
Feb 24, 2026
okurz
force-pushed
the
fix/024_fix_unstables_part2_cache_service
branch
from
15e0de7 to
4282fe5
Compare
okurz
force-pushed
the
fix/024_fix_unstables_part2_cache_service
branch
from
4282fe5 to
ab3eda6
Compare
m-dati
approved these changes
Feb 24, 2026
Member
Author
|
@Martchus ready for your re-review |
Martchus
requested changes
Feb 25, 2026
okurz
force-pushed
the
fix/024_fix_unstables_part2_cache_service
branch
from
ab3eda6 to
1d9f2d4
Compare
Martchus
approved these changes
Feb 26, 2026
Avoid reaping unrelated subprocesses by only waiting for known relevant PIDs. This prevents interfering with components using IPC::Run or backticks which otherwise lose their exit status (0 = -1).
Switch to IPC::Run for rsync execution to capture both stdout and stderr. Locally reset SIGCHLD to DEFAULT during execution to ensure IPC::Run can correctly reap the subprocess and obtain its exit status. Handle cases where status is lost by defaulting to 255.
- Refresh last_use on track_asset conflict. - Use UPSERT in _update_asset to handle cases where assets were purged during download.
- Use random OPENQA_BASE_PORT to avoid clashes. - Globally set OPENQA_TEST_WAIT_INTERVAL to 0.05s.
- Fix incorrect unlinks missing 'localhost' subdirectory. - Wait for background workers to be ready in multiple-worker subtest. - Use background worker for race subtest to reduce lock contention. - Improve diagnostics and verification logic using status API. - Increase initial service startup wait interval.
Confirmed stable after comprehensive fixes and statistical verification. The test was verified to pass consistently during an 8-hour loop run. Related progress issue: https://progress.opensuse.org/issues/196295
- Move `local $SIG{CHLD} = 'DEFAULT';` to
`OpenQA::Utils::run_cmd_with_log_return_error`. This ensures that
IPC::Run can correctly reap child processes and obtain their exit
status, even in environments with custom signal handlers (e.g.
Minion).
Align SQL query definitions in OpenQA::CacheService::Model::Cache with
a consistent q{} style as suggested in PR feedback. This improves
readability and avoids accidental variable interpolation by using
literal string delimiters.
Affected methods:
- _perform_integrity_check
- track_asset
- metrics
- _update_metric
- _increase_metric
- _update_asset_last_use
okurz
force-pushed
the
fix/024_fix_unstables_part2_cache_service
branch
from
1d9f2d4 to
5184629
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Confirmed stable after comprehensive fixes and statistical verification.
The test was verified to pass consistently during an 8-hour loop run.
Related progress issue: https://progress.opensuse.org/issues/196295