Merged
Conversation
zwass
approved these changes
Jun 11, 2025
|
|
||
| if (!status.ok()) { | ||
| LOG(WARNING) << "Failed to hash " << path; | ||
| VLOG(1) << "Failed to hash " << path << ": " << status.getMessage(); |
Member
There was a problem hiding this comment.
I know this merged, but I think this might not be the right thing here.
You're example, size exceeds limit feels routine, and thus maybe does belong down on VLOG, but what if there's a different error? Should that be on WARNING?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes fleetdm/fleet#28577.
TL;DR: When
hashtable is used as scheduled query, the generatedWARNINGlogs fill up the disk space.Sample:
Without
--verbose:With
--verbose: