Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #162 #507
The use of R2/S3 was a legacy decision back when SplitPro was supposed to be a public facing cloud app, which we now reorient more to self hosting usage. As such, the complexity of this setup is unwarranted for and we are switching to local storage only. I did not get around to it before, as the thinking was, yeah, we have working uploads.
This will minimize the setup complexity for initial deployments and you no longer need to commit like 100MB idle RAM to services like Minio (which turned out to be a shitty dependency to have given their recent moves...).
Since we are dropping
v2this is a good chance to get rid of it, as such a change is of course not backwards compatible. The migration, however, should be pretty simple, considering thatS3is a filesystem under the hood. I will write a migration guide for the release (and prerelease), but it should be as simple as fetching your splitpro bucket and saving it in theuploadsDocker volume. A migration script will convert the files for you as well.As a cherry on top, I have added
webpcompression, thumbnail generation and a configurable filesize limit.