Merging user.owe & actors.you_dativus into user.owe_to_you#669
Closed
NeilSCGH wants to merge 2 commits into
Closed
Merging user.owe & actors.you_dativus into user.owe_to_you#669NeilSCGH wants to merge 2 commits into
NeilSCGH wants to merge 2 commits into
Conversation
NeilSCGH
changed the title
NeilSCGH
changed the title
Collaborator
|
Well, I can already see that it breaks the Polish translation. I am more in favor of a more robust solution using ICU, please add this example to #418 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I'm creating a new
ui.expense.user.owe_to_youtranslation, by mergingui.expense.user.owe&actors.you_dativus, and updating/src/components/group/GroupMyBalance.tsxto use this new field.This is used to fix a mistake in the french translation:
ui.expense.user.owe&actors.you_dativuswas giving "dois tu" but in french we should say "te doit".In order to not mess up the other languages, I've manually created
owe_to_youin all of them by merging user.owe + you_davitus, so it should not change anything for them.Checklist
CONTRIBUTING.mdin its entirety