Add heuristics to decompressing archives#209
Merged
marcospb19 merged 6 commits intoouch-org:masterfrom Nov 16, 2021
Merged
Conversation
marcospb19
reviewed
Nov 15, 2021
Member
|
Felling better about this one too!!! I had a bit of trouble trying to review the last one, this one was pretty straight forward, I'll run a couple manual tests before merging, just to see if everything is working properly. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fell way better about this PR, turns out that simplifying stuff is a correct step
fix #151