Skip to content

Randomize Neo4j password at install#99

Merged
MarcOverIP merged 11 commits intooutflanknl:masterfrom
fastlorenzo:neo4j-password
Nov 16, 2020
Merged

Randomize Neo4j password at install#99
MarcOverIP merged 11 commits intooutflanknl:masterfrom
fastlorenzo:neo4j-password

Conversation

@fastlorenzo
Copy link
Collaborator

No description provided.

@fastlorenzo
Copy link
Collaborator Author

Fixes #99

@github-actions github-actions bot added elkserver Related to RedELK server components githubci Related to GitHub actions (CI) installer Related to RedELK installers labels Nov 5, 2020
@fastlorenzo fastlorenzo changed the base branch from maindev to master November 6, 2020 13:49
@MarcOverIP
Copy link
Member

Should also include printing the password at the end of install-elkserver.sh.

Another thing to consider - given issue #104 - these creds should also be stored elsewhere for the jupyter notebooks to include. But I believe its better addressed in an PR for that issue

@fastlorenzo
Copy link
Collaborator Author

Should also include printing the password at the end of install-elkserver.sh.

Another thing to consider - given issue #104 - these creds should also be stored elsewhere for the jupyter notebooks to include. But I believe its better addressed in an PR for that issue

let's first merge PR #100 first then or we'll have a conflict, I'll add the output of the password when done.

Regarding the #104, the password is in .env for now, maybe we should have a step in the installer that would create a specific config file for Jupyter and mount it?

@MarcOverIP MarcOverIP merged commit 3008bc5 into outflanknl:master Nov 16, 2020
@fastlorenzo fastlorenzo deleted the neo4j-password branch November 16, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

elkserver Related to RedELK server components githubci Related to GitHub actions (CI) installer Related to RedELK installers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants