[FEATURE REQUEST] Make document provider visibility independent from locking methods by JuancaG05 · Pull Request #3538 · owncloud/android

JuancaG05 · 2022-02-01T11:52:21Z

Related Issues

Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Release_2.20/3538-document_provider_visibility.md

(1) Remove dialog [FEATURE REQUEST] Make document provider visibility independent from locking methods #3538 (comment) [FIXED]
(2) owncloud listed in doc. prov when no accounts are there [FEATURE REQUEST] Make document provider visibility independent from locking methods #3538 (comment)
(3) Update changelog [FEATURE REQUEST] Make document provider visibility independent from locking methods #3538 (comment) [FIXED]

abelgardep

Just a question related to UX, but the code looks good! Good job @JuancaG05

abelgardep · 2022-02-02T08:32:19Z

+        prefLockAccessDocumentProvider?.setOnPreferenceChangeListener { _: Preference?, newValue: Any ->
+            if (!(newValue as Boolean)) {


I don't know if this is the expected behavior 🤔

Not sure if we should show a dialog to the user when he wants to enable the documents provider(which is the expected behavior) from a UX point of view

IMHO, the dialog does not make sense here since access to document provider is open by default. Warning users when the Lock option is switched off would be the same as warning when the Security section is opened. I'd remove the dialog because the feature meaning is opposite as the previous one.

Ok, I will remove it then. Thank you!

jesmrec · 2022-02-02T13:11:13Z

(1) [DONE]

this one: #3538 (comment)

jesmrec · 2022-02-02T13:19:29Z

(2)

I noticed a tiny difference with the old behaviour

Install app
Go to Settings without adding an account)
Enable Lock access from document provider
Open any app that implements document provider

Current: owncloud is shown as Locked

Expected (before): owncloud is hidden because no accounts were attached yet

Good to fix, but not a blocker

Pixel2 V11
08b6cf94

jesmrec · 2022-02-07T11:44:38Z

(3) [FIXED]

Please, don't forget removing the following entry from the Changelog:

Enhancement - Allow access from document provider preference: [#3379](https://github.com/owncloud/android/issues/3379)

it does not make sense anymore, since the current one covers totally the final result.

fesave · 2022-02-08T08:30:30Z

(3)

Please, don't forget removing the following entry from the Changelog:
Enhancement - Allow access from document provider preference: [#3379](https://github.com/owncloud/android/issues/3379)
it does not make sense anymore, since the current one covers totally the final result.

Removed 😉

fesave · 2022-02-08T10:47:41Z

(3)

Please, don't forget removing the following entry from the Changelog:
Enhancement - Allow access from document provider preference: [#3379](https://github.com/owncloud/android/issues/3379)
it does not make sense anymore, since the current one covers totally the final result.

I think it's fixed, if you can test it thoroughly to make sure I'd appreciate it, anything you see, let me know.

jesmrec · 2022-02-08T11:18:55Z

Everything is correct!! approved on my side and right to 2.20

…not on lock methods

JuancaG05 self-assigned this Feb 1, 2022

JuancaG05 linked an issue Feb 1, 2022 that may be closed by this pull request

[FEATURE REQUEST] Make document provider visibility independent from locking methods #3520

Closed

11 tasks

JuancaG05 marked this pull request as ready for review February 1, 2022 13:12

JuancaG05 requested review from abelgardep and fesave February 1, 2022 13:12

JuancaG05 force-pushed the feature/doc_provider_visibility branch from 6b7e49c to 08b6cf9 Compare February 1, 2022 13:30

abelgardep reviewed Feb 2, 2022

View reviewed changes

JuancaG05 requested review from abelgardep and jesmrec February 2, 2022 13:33

fesave force-pushed the feature/doc_provider_visibility branch 3 times, most recently from 3b92617 to 6268654 Compare February 8, 2022 08:12

fesave force-pushed the feature/doc_provider_visibility branch from e05a78f to 03c7876 Compare February 8, 2022 08:32

jesmrec added the Approved by qa label Feb 8, 2022

JuancaG05 and others added 10 commits February 8, 2022 17:04

Access from document provider now only depends on the preference and …

9571ebe

…not on lock methods

Preference available independently from the lock methods

5bb33d8

Adapted name of unit tests

be1cfb7

Adapted UI tests

1549e84

Added calens file

0525122

Added correct calens file

e699074

No dialog will appear in lock document provider preference

eea0395

Tiny improvement in wording for lock document provider preference

c7cde7f

An entry has been removed from Changelog.

6d2539a

Calens updated

65f35c3

fesave and others added 2 commits February 8, 2022 17:04

ownCloud option hidden because no accounts have been attached yet.

85811f1

Fix a comment with the new behaviour

2c1f93b

abelgardep force-pushed the feature/doc_provider_visibility branch from f8fa7cb to 2c1f93b Compare February 8, 2022 16:05

Update calens item to link other related issues

f72ad92

abelgardep force-pushed the feature/doc_provider_visibility branch from 6571f72 to f72ad92 Compare February 8, 2022 16:18

Calens changelog updated

f958d8a

abelgardep approved these changes Feb 8, 2022

View reviewed changes

abelgardep merged commit d6f4cb4 into master Feb 8, 2022

abelgardep deleted the feature/doc_provider_visibility branch February 8, 2022 17:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEATURE REQUEST] Make document provider visibility independent from locking methods#3538

[FEATURE REQUEST] Make document provider visibility independent from locking methods#3538
abelgardep merged 14 commits into
masterfrom
feature/doc_provider_visibility

JuancaG05 commented Feb 1, 2022 •

edited by jesmrec

Loading

Uh oh!

abelgardep left a comment

Uh oh!

Uh oh!

Uh oh!

abelgardep Feb 2, 2022

Uh oh!

jesmrec Feb 2, 2022

Uh oh!

JuancaG05 Feb 2, 2022

Uh oh!

jesmrec commented Feb 2, 2022 •

edited

Loading

Uh oh!

jesmrec commented Feb 2, 2022

Uh oh!

jesmrec commented Feb 7, 2022 •

edited

Loading

Uh oh!

fesave commented Feb 8, 2022

(3)

Uh oh!

fesave commented Feb 8, 2022 •

edited

Loading

(3)

Uh oh!

jesmrec commented Feb 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		prefLockAccessDocumentProvider?.setOnPreferenceChangeListener { _: Preference?, newValue: Any ->
		if (!(newValue as Boolean)) {

Conversation

JuancaG05 commented Feb 1, 2022 • edited by jesmrec Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Issues

QA

Uh oh!

abelgardep left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

abelgardep Feb 2, 2022

Choose a reason for hiding this comment

Uh oh!

jesmrec Feb 2, 2022

Choose a reason for hiding this comment

Uh oh!

JuancaG05 Feb 2, 2022

Choose a reason for hiding this comment

Uh oh!

jesmrec commented Feb 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

(1) [DONE]

Uh oh!

jesmrec commented Feb 2, 2022

(2)

Uh oh!

jesmrec commented Feb 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

(3) [FIXED]

Uh oh!

fesave commented Feb 8, 2022

(3)

Uh oh!

fesave commented Feb 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

(3)

Uh oh!

jesmrec commented Feb 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JuancaG05 commented Feb 1, 2022 •

edited by jesmrec

Loading

jesmrec commented Feb 2, 2022 •

edited

Loading

jesmrec commented Feb 7, 2022 •

edited

Loading

fesave commented Feb 8, 2022 •

edited

Loading