Skip to content

[TECHNICAL] Upgrade min SDK to Android 6 (v23)#4036

Merged
JuancaG05 merged 5 commits into
masterfrom
technical/min_sdk_23
May 25, 2023
Merged

[TECHNICAL] Upgrade min SDK to Android 6 (v23)#4036
JuancaG05 merged 5 commits into
masterfrom
technical/min_sdk_23

Conversation

@JuancaG05

@JuancaG05 JuancaG05 commented May 8, 2023

Copy link
Copy Markdown
Contributor

Related Issues

App: #3245

Library PR (if needed): owncloud/android-library#566

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@JuancaG05 JuancaG05 self-assigned this May 8, 2023
@JuancaG05 JuancaG05 linked an issue May 8, 2023 that may be closed by this pull request
9 tasks
@JuancaG05 JuancaG05 force-pushed the technical/min_sdk_23 branch from 0499790 to 1c0df9c Compare May 9, 2023 06:34
@JuancaG05

Copy link
Copy Markdown
Contributor Author

Changes performed:

  • In owncloudComLibrary module, USE_CREDENTIALS, MANAGE_ACCOUNTS and AUTHENTICATE_ACCOUNTS permissions have been removed (they don't exist in API >= 23)
  • In owncloudApp module, GET_ACCOUNTS permission has been removed (not needed in API >= 23 to access accounts, our use case. More info: https://developer.android.com/reference/android/Manifest.permission#GET_ACCOUNTS). USE_CREDENTIALS, MANAGE_ACCOUNTS and AUTHENTICATE_ACCOUNTS permissions have been removed as well.
  • In owncloudData module, GET_ACCOUNTS and AUTHENTICATE_ACCOUNTS permissions have been removed.
  • For notifications, the pending intents now will always have the FLAG_IMMUTABLE (for API < 23 they didn't, so this behaviour won't happen anymore).
  • BiometricManager and all the related classes will always be called since from API 23 onwards, Android supports biometrics.

@JuancaG05 JuancaG05 force-pushed the technical/min_sdk_23 branch from 288a9d5 to 45cecdf Compare May 9, 2023 10:47
@JuancaG05 JuancaG05 requested a review from jabarros May 9, 2023 10:55

@jabarros jabarros left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesmrec

jesmrec commented May 17, 2023

Copy link
Copy Markdown
Member

Changes performed:

In owncloudComLibrary module, USE_CREDENTIALS, MANAGE_ACCOUNTS and AUTHENTICATE_ACCOUNTS permissions have been removed (they don't exist in API >= 23)
In owncloudApp module, GET_ACCOUNTS permission has been removed (not needed in API >= 23 to access accounts, our use case. More info: https://developer.android.com/reference/android/Manifest.permission#GET_ACCOUNTS). USE_CREDENTIALS, MANAGE_ACCOUNTS and AUTHENTICATE_ACCOUNTS permissions have been removed as well.
In owncloudData module, GET_ACCOUNTS and AUTHENTICATE_ACCOUNTS permissions have been removed.
For notifications, the pending intents now will always have the FLAG_IMMUTABLE (for API < 23 they didn't, so this behaviour won't happen anymore).
BiometricManager and all the related classes will always be called since from API 23 onwards, Android supports biometrics.

that means, changes only affect old code that is not longer supported because minimum API jumped to 23. No new behaviour or existing behaviour changed due to changes, right?

@JuancaG05

Copy link
Copy Markdown
Contributor Author

Changes performed:

In owncloudComLibrary module, USE_CREDENTIALS, MANAGE_ACCOUNTS and AUTHENTICATE_ACCOUNTS permissions have been removed (they don't exist in API >= 23)
In owncloudApp module, GET_ACCOUNTS permission has been removed (not needed in API >= 23 to access accounts, our use case. More info: https://developer.android.com/reference/android/Manifest.permission#GET_ACCOUNTS). USE_CREDENTIALS, MANAGE_ACCOUNTS and AUTHENTICATE_ACCOUNTS permissions have been removed as well.
In owncloudData module, GET_ACCOUNTS and AUTHENTICATE_ACCOUNTS permissions have been removed.
For notifications, the pending intents now will always have the FLAG_IMMUTABLE (for API < 23 they didn't, so this behaviour won't happen anymore).
BiometricManager and all the related classes will always be called since from API 23 onwards, Android supports biometrics.

that means, changes only affect old code that is not longer supported because minimum API jumped to 23. No new behaviour or existing behaviour changed due to changes, right?

Yes, we could say it like that. No new behaviour, and existing behaviour was adapted to only API >= 23, but no functional changes.

@jesmrec

jesmrec commented May 17, 2023

Copy link
Copy Markdown
Member

So, testing will be moved to regression stage. Just checking that everything that works is still working.

Nothing to do from my side

@JuancaG05 JuancaG05 force-pushed the technical/min_sdk_23 branch 2 times, most recently from e2bbba2 to bffcd59 Compare May 19, 2023 07:09
@JuancaG05 JuancaG05 force-pushed the technical/min_sdk_23 branch from bffcd59 to d95cb79 Compare May 25, 2023 11:36
@JuancaG05 JuancaG05 merged commit 27a12f0 into master May 25, 2023
@JuancaG05 JuancaG05 deleted the technical/min_sdk_23 branch May 25, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TECHNICAL] Upgrade min SDK to Android 6 (v23)

3 participants