[FEATURE REQUEST] Show same remove dialog for every kind of file or folder by Aitorbp · Pull Request #4404 · owncloud/android

Aitorbp · 2024-05-13T13:15:47Z

Related Issues

App: #4377

Add changelog files for the fixed issues in folder changelog/unreleased. More info here
Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

(1) Crash when changing orientation [FEATURE REQUEST] Show same remove dialog for every kind of file or folder #4404 (comment) [FIXED]

joragua

Some changes here

Aitorbp · 2024-06-17T11:39:56Z

Add new shortcut icon to remove dialog when shortcut pr will be merged.

JuancaG05

Several things to check here @Aitorbp

JuancaG05

Please, again, remove that new release note which shouldn't be here...

JuancaG05

LGTM

jesmrec · 2024-06-21T07:08:56Z

jesmrec · 2024-06-21T07:17:31Z

(1) [FIXED]

Select any item on the file list and click on Remove
Change device orientation

Current:

app crashes. This is the stacktrace:

Process: com.owncloud.android.debug, PID: 29844
                 java.lang.RuntimeException: Unable to start activity ComponentInfo{com.owncloud.android.debug/com.owncloud.android.ui.activity.FileDisplayActivity}: androidx.fragment.app.Fragment$InstantiationException: Unable to instantiate fragment com.owncloud.android.presentation.files.removefile.RemoveFilesDialogFragment: could not find Fragment constructor
                 	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3449)
                 	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3601)
                 	at android.app.ActivityThread.handleRelaunchActivityInner(ActivityThread.java:5456)
                 	at android.app.ActivityThread.handleRelaunchActivity(ActivityThread.java:5362)
                 	at android.app.servertransaction.ActivityRelaunchItem.execute(ActivityRelaunchItem.java:69)
                 	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
                 	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
                 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2066)
                 	at android.os.Handler.dispatchMessage(Handler.java:106)
                 	at android.os.Looper.loop(Looper.java:223)
                 	at android.app.ActivityThread.main(ActivityThread.java:7656)
                 	at java.lang.reflect.Method.invoke(Native Method)
                 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
                 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
                 Caused by: androidx.fragment.app.Fragment$InstantiationException: Unable to instantiate fragment com.owncloud.android.presentation.files.removefile.RemoveFilesDialogFragment: could not find Fragment constructor
                 	at androidx.fragment.app.Fragment.instantiate(Fragment.java:681)
                 	at androidx.fragment.app.FragmentContainer.instantiate(FragmentContainer.java:57)
                 	at androidx.fragment.app.FragmentManager$3.instantiate(FragmentManager.java:507)
                 	at androidx.fragment.app.FragmentState.instantiate(FragmentState.java:81)
                 	at androidx.fragment.app.FragmentStateManager.<init>(FragmentStateManager.java:85)
                 	at androidx.fragment.app.FragmentManager.restoreSaveStateInternal(FragmentManager.java:2507)
                 	at androidx.fragment.app.FragmentManager.attachController(FragmentManager.java:2667)
                 	at androidx.fragment.app.FragmentController.attachHost(FragmentController.java:117)
                 	at androidx.fragment.app.FragmentActivity.lambda$init$3$androidx-fragment-app-FragmentActivity(FragmentActivity.java:140)
                 	at androidx.fragment.app.FragmentActivity$$ExternalSyntheticLambda3.onContextAvailable(Unknown Source:2)
                 	at androidx.activity.contextaware.ContextAwareHelper.dispatchOnContextAvailable(ContextAwareHelper.java:99)
                 	at androidx.activity.ComponentActivity.onCreate(ComponentActivity.java:352)
                 	at androidx.fragment.app.FragmentActivity.onCreate(FragmentActivity.java:217)
                 	at com.owncloud.android.ui.activity.DrawerActivity.onCreate(DrawerActivity.kt:588)
                 	at com.owncloud.android.ui.activity.FileActivity.onCreate(FileActivity.java:119)
                 	at com.owncloud.android.ui.activity.FileDisplayActivity.onCreate(FileDisplayActivity.kt:197)
                 	at android.app.Activity.performCreate(Activity.java:8000)
                 	at android.app.Activity.performCreate(Activity.java:7984)
                 	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1309)
                 	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3422)
                 	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3601) 
                 	at android.app.ActivityThread.handleRelaunchActivityInner(ActivityThread.java:5456) 
                 	at android.app.ActivityThread.handleRelaunchActivity(ActivityThread.java:5362) 
                 	at android.app.servertransaction.ActivityRelaunchItem.execute(ActivityRelaunchItem.java:69) 
                 	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135) 
                 	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95) 
                 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2066) 
                 	at android.os.Handler.dispatchMessage(Handler.java:106) 
                 	at android.os.Looper.loop(Looper.java:223) 
                 	at android.app.ActivityThread.main(ActivityThread.java:7656) 
                 	at java.lang.reflect.Method.invoke(Native Method) 
                 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592) 
                 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947) 
                 Caused by: java.lang.NoSuchMethodException: com.owncloud.android.presentation.files.removefile.RemoveFilesDialogFragment.<init> []
                 	at java.lang.Class.getConstructor0(Class.java:2332)
                 	at java.lang.Class.getConstructor(Class.java:1728)
                 	at androidx.fragment.app.Fragment.instantiate(Fragment.java:666)

Expected:

no crash

Pixel 2, Android 11
015c716f1

Aitorbp · 2024-06-21T11:31:29Z

The last report is ready to test @jesmrec. Also I added in another commit one fix related to release note of shortcut. I added here because that pr is already merged.

jesmrec · 2024-06-21T12:39:50Z

Crash is fixed and feature is OK from my side.

About this

Also I added in another commit one fix related to release note of shortcut. I added here because that pr is already merged.

I'd change to avoid the word FAB in the release notes, that's pretty technically scoped to Android and non-advanced users will not understand.

Aitorbp · 2024-06-21T13:06:43Z

Crash is fixed and feature is OK from my side.

About this

Also I added in another commit one fix related to release note of shortcut. I added here because that pr is already merged.

I'd change to avoid the word FAB in the release notes, that's pretty technically scoped to Android and non-advanced users will not understand.

Changed by floating button @jesmrec

provisionally out of the team

jesmrec · 2024-06-24T07:28:14Z

Approved

…ity to display thumbnails(img, mp4, folders...)

…se notes relate to this development

…ogFragment

Aitorbp self-assigned this May 13, 2024

Aitorbp force-pushed the feature/show_same_remove_dialog_for_every_file_folder branch from 6bef5ff to 98f3ddf Compare May 13, 2024 13:21

Aitorbp linked an issue May 14, 2024 that may be closed by this pull request

[FEATURE REQUEST] Show same remove dialog for every kind of file or folder #4377

Closed

8 tasks

Aitorbp force-pushed the feature/show_same_remove_dialog_for_every_file_folder branch from 5f9c0e0 to 0b29948 Compare May 14, 2024 14:57

Aitorbp requested a review from JuancaG05 May 14, 2024 16:17

joragua previously requested changes May 21, 2024

View reviewed changes

Aitorbp force-pushed the feature/show_same_remove_dialog_for_every_file_folder branch 4 times, most recently from 72c28ff to bf7df0e Compare June 4, 2024 07:25

Aitorbp force-pushed the feature/show_same_remove_dialog_for_every_file_folder branch from d4c5d09 to f6c51c3 Compare June 14, 2024 13:54

JuancaG05 requested changes Jun 18, 2024

View reviewed changes

Aitorbp force-pushed the feature/show_same_remove_dialog_for_every_file_folder branch 2 times, most recently from cb11037 to a9b7d13 Compare June 18, 2024 08:21

Aitorbp requested a review from JuancaG05 June 18, 2024 08:46

JuancaG05 requested changes Jun 18, 2024

View reviewed changes

Comment thread changelog/unreleased/4404 Outdated

Comment thread changelog/unreleased/4404 Outdated

Comment thread owncloudApp/src/main/res/values/strings.xml Outdated

Aitorbp force-pushed the feature/show_same_remove_dialog_for_every_file_folder branch from 8f01d7d to f2f8a83 Compare June 18, 2024 12:15

Aitorbp requested a review from JuancaG05 June 18, 2024 12:20

Aitorbp force-pushed the feature/show_same_remove_dialog_for_every_file_folder branch from 9c5e5bd to 9c525a2 Compare June 20, 2024 08:52

JuancaG05 requested changes Jun 20, 2024

View reviewed changes

Aitorbp requested a review from JuancaG05 June 20, 2024 11:50

JuancaG05 approved these changes Jun 20, 2024

View reviewed changes

Aitorbp force-pushed the feature/show_same_remove_dialog_for_every_file_folder branch from 30a8e90 to b3d2900 Compare June 24, 2024 06:35

jesmrec added the Approved by qa label Jun 24, 2024

Aitorbp and others added 11 commits June 24, 2024 10:33

feat: unify remove dialog in RemoveFilesDialogFragment and functional…

87126ab

…ity to display thumbnails(img, mp4, folders...)

fix: changed place of varaibles

1b3be20

fix: deleted release notes in this pr and modified the previous relea…

be005ae

…se notes relate to this development

fix: tiny change in release notes and removed docs in RemoveFilesDial…

74640f1

…ogFragment

fix: new changes the release notes

9448f75

chore: add release notes and deleted previous one

840311d

docs: calens changelog updated

56b2130

feat: Added icon shortcut to RemoveFilesDialogFragment

5243648

fix: changed parameters logic: added bundle arguments

12a2b36

fix: changed arguments by requireArguments()

323036d

fix: changed in te release notes the shortcut subtitle (floating button)

a9cc631

Aitorbp force-pushed the feature/show_same_remove_dialog_for_every_file_folder branch from b3d2900 to a9cc631 Compare June 24, 2024 09:44

Aitorbp merged commit 697e742 into master Jun 24, 2024

Aitorbp deleted the feature/show_same_remove_dialog_for_every_file_folder branch June 24, 2024 10:02

Conversation

Aitorbp commented May 13, 2024 • edited by jesmrec Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Issues

QA

Uh oh!

joragua left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Aitorbp commented Jun 17, 2024

Uh oh!

JuancaG05 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JuancaG05 left a comment

Choose a reason for hiding this comment

Uh oh!

JuancaG05 left a comment

Choose a reason for hiding this comment

Uh oh!

jesmrec commented Jun 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jesmrec commented Jun 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

(1) [FIXED]

Uh oh!

Aitorbp commented Jun 21, 2024

Uh oh!

jesmrec commented Jun 21, 2024

Uh oh!

Aitorbp commented Jun 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jesmrec commented Jun 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Aitorbp commented May 13, 2024 •

edited by jesmrec

Loading

jesmrec commented Jun 21, 2024 •

edited

Loading

jesmrec commented Jun 21, 2024 •

edited

Loading

Aitorbp commented Jun 21, 2024 •

edited

Loading