[FIX] Unwanted DELETE operations when synchronization in single file fails

[JuancaG05]

When performing a read remote file operation (synchronization over a single file), if the account in the OwncloudClient is null, we'll throw an AccountNotFoundException. This will be handled in 3 different views:

• In the main file list view
• In the file details view
• In the image preview view

In the 3 cases, we'll show a Snackbar telling Sync failed, you need to log in again, suggesting that by repeating the login process, the problem can be solved (since we'll save again the account, which might have been lost in some migration process from a very old version).

Also, we changed the way to handle the 404 error of a PROPFIND. Previously, we deleted locally and remotely the file that we requested in the PROPFIND, now we just remove it locally (since if we receive a 404, the file shouldn't exist in remote), avoiding sending DELETE requests.

Related Issues

App: https://github.com/owncloud/enterprise/issues/6638

• Add changelog files for the fixed issues in folder changelog/unreleased. More info here
• Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

---

QA

[TheOneRing]

Sounds good to me

[joragua]

LGTM! 😄

[jesmrec]

Not able to reproduce the problem of the non-existing account without tricking the code. Users' feedback turns important here, because this is not an expected behaviour and it is not in our hands to control it (OS feature).

About the DELETE sent after a 404, it's fixed. DELETE remote operation is not sent anymore, and local copy is removed 👍

[jesmrec]

Just a question here:

In the 3 cases, we'll show a Snackbar telling Sync failed, you need to log in again

When auth is lost due to an invalid token, we use to show a snackbar with the message and a button/link that prompts the user to the login view. How difficult is to add that button to the snackbar in the same way? like:

[JuancaG05]

Just a question here:

In the 3 cases, we'll show a Snackbar telling Sync failed, you need to log in again

When auth is lost due to an invalid token, we use to show a snackbar with the message and a button/link that prompts the user to the login view. How difficult is to add that button to the snackbar in the same way? like:

Should be added now 😃

[jesmrec]

Should be added now 😃

Correctly added and working in list of files, details view and image preview. Ready to go.