[FEATURE REQUEST] Remove a space member

[joragua]

Related Issues

App: #4725

• Add changelog files for the fixed issues in folder changelog/unreleased. More info here
• Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

---

QA

Reports: https://github.com/owncloud/QA/blob/master/Mobile/Android/Executions/Release_4.8/Spaces%20-%20Remove%20member.md

• (1) Adding new manager does not add trashbin to the existing one [FEATURE REQUEST] Remove a space member #4768 (comment) [FIXED]
• (2) Improve trashbin accessibility message [FEATURE REQUEST] Remove a space member #4768 (comment) [FIXED]

[jesmrec]

moving to QA, since #4768 (comment) is out of CR scope. In case changes are required, will be handled as a QA report.

[jesmrec]

(1) [FIXED]

All steps to be done in the mobile app:

1. Current user is the only manager in a space -> no trashbin ✅
2. Add another user as a manager -> new manager has trashbin ✅ but the existing manager does not ❌
3. Add another user as a manager -> all managers have now trashbin ✅

Xiaomi Redmi Note 13, Android 15
Galaxy Tab A8, Android 15
3d0e7993

[jesmrec]

CR approved, QA time

[joragua]

(1): This bug is reproducible after applying the commit that comes from this comment on the CR: #4768 (comment)

I've checked it, and the best solution here is to revert all the changes and removed that commit. It's more efficient to use SpaceMembersDiffUtil instead of mixing both methods (avoiding notifyItemRangeChanged()). Using the notify method also causes all animations to be lost, which feels so strange for the UX...

I've removed the commit and it should be fixed now 😄

[jesmrec]

(2) [FIXED]

About accessibility:

the trashbin icon is spelt as Remove member. Is there any chance to add the name of the user to delete? so, it'd say Remove member Alice (for example)

Xiaomi Redmi Note 13, Android 15
6863e3f7f

[joragua]

Regarding (2): With the last commit, Talkback should now read "Remove member <displayName> button"

[jesmrec]

(1) and (2) fixed

[jesmrec]

Approved on my side 🚀