If there is no browser history, exit the slideshow by calling stop.#463
Closed
setnes wants to merge 4 commits intoowncloud:masterfrom
Closed
If there is no browser history, exit the slideshow by calling stop.#463setnes wants to merge 4 commits intoowncloud:masterfrom
setnes wants to merge 4 commits intoowncloud:masterfrom
Conversation
Contributor
|
Thanks, that sounds like a sensible solution :) Did you test it with various scenarios or just by sharing a Gallery link? |
Contributor
Author
|
I have tried this for awhile, and it seems to be working nicely. What should be tested specifically? I have tried from an image at the top level of a shared link as well as with images in sub-directories of a shared link. Both work fine. I have tried from a browser that is logged into an OwnCloud account as well as from browsers that are using only the access that the shared link provides... etc. |
Contributor
What you've described + normal use as a logged in user who just browses through his pictures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #460.