fix(translation-sync): replace git rm with rm in cleanup step#63
Merged
Conversation
git rm requires a valid git safe.directory context which is not available inside the container for subsequent steps after checkout. The files being removed are unsupported locales; plain rm is sufficient since peter-evans/create-pull-request handles staging all filesystem changes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
DeepDiver1975
force-pushed
the
fix/translation-cleanup-git-rm
branch
from
814a721 to
269bcab
Compare
Member
Author
|
seems to be working .... https://github.com/owncloud/activity/actions/runs/25562440332/job/75037262702 |
mmattel
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git rm -fto remove unsupported locale files (or_IN,uz,yo,ne)fatal: detected dubious ownership in repository(exit 123) because the job runs inside theowncloudci/transifexcontainer where the workspace UID differs from the container process UID — git's safe.directory protection kicks in for all steps after checkoutrm -fis correct here:peter-evans/create-pull-requestalready stages all filesystem changes (including tracked file deletions) before creating the PR commit, so the git layer was never neededTest plan
mode: oldand confirm the cleanup step no longer fails with exit 123or_IN.*,uz.*,yo.*,ne.*files that were previously tracked🤖 Generated with Claude Code