feat(acceptance): add server-version input to allow custom ownCloud server version#68
Closed
DeepDiver1975 wants to merge 2 commits into
Closed
Conversation
…erver version
Adds a new optional input server-version (default: 'daily-master-qa')
that is passed as PLUGIN_VERSION to the owncloudci/core Docker image in
both the main and federated install steps.
The owncloudci/core image constructs the download URL as:
owncloud-${PLUGIN_VERSION}.tar.bz2
and falls back through daily/ → testing/ → stable/ channels, so:
daily-master-qa → owncloud-daily-master-qa.tar.bz2 (OC11 nightly, from daily/)
10.16.2-qa → owncloud-10.16.2-qa.tar.bz2 (OC10 QA build, from testing/)
All existing callers are unaffected since daily-master-qa remains the default.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Adds optional app-ref input to acceptance.yml (defaults to repo default branch) so callers can pin a specific tag, branch, or SHA for the app checkout. Adds two example jobs to test.yml: - acceptance-api-oc10: tests against OC10 (server-version: 10.16.2-qa, app-ref: v0.6.1 which is the last OC10-compatible impersonate release) - acceptance-api-explicit-default: confirms server-version wiring by passing the default value (daily-master-qa) explicitly Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Member
Author
|
this is not going to work at the moment -> close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new optional input
server-version(default:'daily-master-qa') toacceptance.yml, passed asPLUGIN_VERSIONto theowncloudci/coreDocker imagein both the main and federated install steps.
Motivation
OC10-targeted apps (e.g.
richdocuments@release-4.2.3withmax-version="10") cannot be enabled on the OC11 nightly that the workflow currently installsunconditionally. There is no way for callers to override the server version.
How it works
The
owncloudci/coreimage constructsowncloud-${PLUGIN_VERSION}.tar.bz2and falls back through channels in order:server-versionvaluedaily-master-qa(default)owncloud-daily-master-qa.tar.bz2daily/10.16.2-qaowncloud-10.16.2-qa.tar.bz2testing/Backward compatibility
All existing callers that do not pass
server-versioncontinue to usedaily-master-qa— no behaviour change.Usage (OC10 backport branch)