fix(formatter): remove defaultFormatter dependency for codeActionsOnSave#236
Open
alphatr wants to merge 1 commit into
Open
fix(formatter): remove defaultFormatter dependency for codeActionsOnSave#236alphatr wants to merge 1 commit into
alphatr wants to merge 1 commit into
Conversation
Member
|
I do not like adding a second command specific for oxfmt, when the editor does already have a command for formatting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, using oxfmt via
editor.codeActionsOnSaverequired settingeditor.defaultFormatterto"oxc.oxc-vscode", because the code action relied on VS Code's built-ineditor.action.formatDocumentcommand. This change removes that dependency.What changed
oxc.formatDocumentthat directly calls the LSPtextDocument/formattingrequest via the language client, bypassing the need foreditor.defaultFormatterdefaultFormattercheck: The code actions provider no longer checks whethereditor.defaultFormatteris set to"oxc.oxc-vscode"editor.defaultFormatteris now optional when usingcodeActionsOnSave, and is only recommended for manual formattingTest plan
source.format.oxcincodeActionsOnSaveworks without settingeditor.defaultFormattereditor.formatOnSavewitheditor.defaultFormatterset to"oxc.oxc-vscode"still worksFormat Documentcommand still works