linter: Difference in `eslint/no-shadow` rule behavior vs original ts-eslint rule

[connorshea]

What version of Oxlint are you using?

1.48.0

What command did you run?

oxlint

What does your .oxlintrc.json config file look like?

{
  "$schema": "./node_modules/oxlint/configuration_schema.json",
  "plugins": [
    "typescript"
  ],
  "categories": {
    "correctness": "off"
  },
  "rules": {
    "eslint/no-shadow": "error"
  }
}

What happened?

I have this code:

import { memo } from 'react';

const FooBarComponent = memo(function FooBarComponent() {
  return <div>Foo</div>;
});

In typescript-eslint's no-shadow rule, there is no warning/error here. In Oxlint, there is.

• typescript-eslint Playground
• Oxc Playground

[connorshea]

The behavior does match the original ESLint rule, though, so I guess it depends on which we believe to be correct.

Playground link

[camc314]

Lets align with typescript-eslint.

Great find 🙏

[connorshea]

FWIW I did find this commit which I guess explains why it errors in ESLint? But only on v10: eslint/eslint@43677de

[bradzacher]

yeah the alignment should be with eslint core here -- so it's a bug in typescript-eslint

[connorshea]

yeah the alignment should be with eslint core here -- so it's a bug in typescript-eslint

I was afraid you'd say that :)

[camc314]

🫠 I only read this after merging rip