Use Tailwind 3.0#515
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/oxidecomputer/console-ui-storybook/8EANEQDMhaH5PtrkJEEnobSXKK48 |
|
Preview will be deployed at https://console-git-tailwind-3.0.internal.oxide.computer |
| * TODO: This isn't respected, need an upstream fix. | ||
| * @see https://github.com/tailwindlabs/tailwindcss/issues/3949 | ||
| */ | ||
| variantOrder: ['children', ...defaultConfig.variantOrder, 'svg'], |
There was a problem hiding this comment.
@zephraph I think this isn't needed anymore but let me know
There was a problem hiding this comment.
If it's working, it's not needed 😄. I mean, this never did anything to begin with due to the upstream bug.
| }), | ||
| childrenPlugin, | ||
| plugin(({ addVariant }) => addVariant('svg', '& > svg')), | ||
| plugin(({ addVariant }) => addVariant('children', '& > *')), |
|
The deploy is failing because there's a |
2 participants
I mostly want this so we can use
stroke-<color>(TW PR), but regardless it's a small change for us and 3.0 proper will be out soon.Only minor changes to variant order were required. I made an issue about that (tailwindlabs/tailwindcss#6016), which I then figured out was a dupe of tailwindlabs/tailwindcss#6016, which is fixed in tailwindlabs/tailwindcss#6018, which will be in the next alpha.