Skip to content

complete LetsDrill challenge #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeslieKornes wants to merge 1 commit into
base: master
Choose a base branch
from
Open

complete LetsDrill challenge #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions letsdrill.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,34 @@
def get_letter_grade(integer)

#Put your code here!

if integer.between?(90,100)
Copy link
Copy Markdown
Member

@jaybobo jaybobo May 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i haven't seen anyone use .between to solve this before i dont think. cool!

other options here might be >= or...

a range...

case integer
when 90..100
  ...
end

"A"
elsif integer.between?(80,90)
"B"
elsif integer.between?(70,80)
"C"
elsif integer.between?(60,70)
"D"
elsif
"F"
end

end

def shortest_string(array)

#Put your code here!
array.sort_by(&:length).first
Copy link
Copy Markdown
Member

@jaybobo jaybobo May 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, use of Symbol#to_proc!

pro-tip: .min_by will let you drop your use of .first and make this even more concise.


end



### Don't touch anything below this line ###

p "Fetch Letter Grade: You should have 2 trues"
p get_letter_grade(89) == "B"
p get_letter_grade(73) == "C"
p get_letter_grade(89) == "B"
p get_letter_grade(73) == "C"
p
p "Shortest String: You should have 3 trues"
p shortest_string(["touch","this", "car"]) == "car"
p shortest_string([]) == nil
p shortest_string(["can", "a", "solve", "Find", "solution"]) == "a"
p shortest_string([]) == nil
p shortest_string(["can", "a", "solve", "Find", "solution"]) == "a"