fix issue #975: last character not a \n after format in Intellij #1113
Open
bodote wants to merge 3 commits intopalantir:developfrom
Open
fix issue #975: last character not a \n after format in Intellij #1113bodote wants to merge 3 commits intopalantir:developfrom
\n after format in Intellij #1113bodote wants to merge 3 commits intopalantir:developfrom
Conversation
Member
|
Thanks for your interest in palantir/palantir-java-format, @bodote! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
Generate changelog in
|
\n after format in Intellij
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
WHEN creating a new java class using Intellij with palantir-java-format plugin enabled for formating all java files
AND using maven-spotless with palantirJavaFormat
AND the last line in a java file is not an empty line but just } with no
\nappendedTHEN the
mvn spotless:checkusing palantirJavaFormat failsBECAUSE the Intellij with palantir-java-format plugin enabled does NOT add this required
\nAfter this PR
fixes : #975
change
PalantirJavaFormatFormattingService.javafromrequest.onTextReady(formattedText);torequest.onTextReady(formattedText.trim() + "\n");so that the required\nis added when Intellij formats a source filePossible downsides?