flag_value:str and default=False produces str value

[QuLogic]

rasterio has the following code:

@click.option('--all', 'allmd', callback=all_handler, flag_value='like',
              is_eager=True, default=False,
              help="Copy all metadata items from the template file.")

With click 8.2.1, this produced allmd=False (i.e., a boolean value) when called without argument, but in 8.2.2 is produces allmd='False' (i.e., a string).

I have whittled it down to the following minimal example:

import click

@click.command('edit-info', short_help="Edit dataset metadata.")
@click.option('--all', 'allmd', flag_value='like', default=False)
def edit(allmd):
    print(f'HERE is allmd: {allmd!r}')

if __name__ == '__main__':
    edit()

That is, specifying flag_value as a string and default=False together produced a string now, but a boolean a release ago.

A bisection points to 9caedb9 as the first bad commit. I have tested against main (i.e., with #3030 merged) as well, but it is not fixed there.

Environment:

• Python version: 3.13.3
• Click version: 8.2.2 and main (10b77f9)

[QuLogic]

Note, I am unfamiliar with click and just trying to get rasterio's tests working again. It is possible that they are doing something wrong here, but it also seems like such a change may not have been intentional for a bugfix of 8.2.1->8.2.2 given it was some long-standing behaviour.

[davidism]

Fixed in #3030

[QuLogic]

It is not, I explicitly said I tried main.

[davidism]

default=False was never intended to be valid there. Either use a default that matches the type of the flag_value (str in this case), or omit default entirely and it will be None if not given. default=True is a special case that uses the flag value when there are multiple flags.

[QuLogic]

OK, thank you. I will report this to rasterio upstream and maybe make a PR with your suggestion if I can make it work.