Fix speculative empty string check#3299
Merged
Rowlando13 merged 1 commit intopallets:stablefrom Apr 8, 2026
Merged
Conversation
kdeldycke
force-pushed
the
fix-default-eq-check
branch
from
7320b40 to
19cfea7
Compare
Collaborator
Author
|
I could not find any regression regarding default values so this PR is ready to be merged. |
kdeldycke
force-pushed
the
fix-default-eq-check
branch
from
19cfea7 to
d340b0c
Compare
Collaborator
|
Can you add a changelog entry. |
kdeldycke
added a commit
to kdeldycke/click
that referenced
this pull request
Apr 9, 2026
Add missing entries for pallets#3238 and pallets#3299 Fix wrong version for pallets#3245 changelog entry Lint section format
Collaborator
Author
Ah you're right. Just did that in 1339fd3 . I am not touching |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3298 by checking against a speculative empty string.
That not unreasonable given the hard-coded nature of the empty string.