Skip to content

fix: guard default value comparison against types with strict __eq__ #3327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bahtya wants to merge 1 commit into from
+1 −1
Closed

fix: guard default value comparison against types with strict __eq__ #3327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/click/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3110,7 +3110,7 @@ def get_help_extra(self, ctx: Context) -> types.OptionHelpExtra:
)[1]
elif self.is_bool_flag and not self.secondary_opts and not default_value:
default_string = ""
elif default_value == "":
elif isinstance(default_value, str) and default_value == "":
default_string = '""'
else:
default_string = str(default_value)
Expand Down