Open
Conversation
When `show_default` is set to a string on an option with `prompt=True`, use that string in the prompt instead of the actual default value, matching the behavior of the help text. Squashed from pallets#2837 by Josh Cannon (@thejcannon).
This was referenced Apr 9, 2026
kdeldycke
force-pushed
the
show-default-string-in-prompt
branch
from
ea636eb to
06e47c7
Compare
Collaborator
Author
|
This PR is ready to be merge in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR build-up on #2837 (original contributor deleted its fork) and #3165 (revival based on AI slop) to use the value of
show_defaultin prompt if the latter is a string. Which aligns the display with the help screen.Also adds a lot of unit tests for edge-cases for default prompt displaying.
This closes #2836.