Repository navigation
Conversation
cmp0xff
requested changes
Nov 4, 2026
| check(assert_type(IRIS_DF.plot.line(), Axes), Axes) | ||
| check(assert_type(IRIS_DF.plot(kind="line"), Axes), Axes) | ||
| check(assert_type(IRIS_DF.plot.line(subplots=True), np_ndarray_object), np.ndarray) | ||
| check(assert_type(IRIS_DF.plot.line(subplots=True), np_1darray_object), np.ndarray) |
Contributor
There was a problem hiding this comment.
Suggested change
| check(assert_type(IRIS_DF.plot.line(subplots=True), np_1darray_object), np.ndarray) | |
| check(assert_type(IRIS_DF.plot.line(subplots=True), np_1darray_object), np_1darray_object) |
basically we try to avoid using np.ndarray and use np_1darray, np_2darray, np_ndarray or their variations, like #1588. Please also propagate the idea to other places and other PRs that you own.
jorenham
force-pushed
the
PlotAccessor/shape-typing
branch
from
November 5, 2026 14:51
a26bbc3 to
0b38daf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PlotAccessormethod overloads returningobject_numpy arrays now return a 1d array whenlayout=None(default) and 2d array whenlayout: tuple[int, int].For consistency with
np_1darray_object, I introduced a new_typingalias for the 2d case; hope that's ok.assert_type()to assert the type of any return value)AGENTS.md.