TST: add regression test for Timestamp(fold=..., tz=<str>) (GH-55932)#65422
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jbrockmendel
added
the
Testing
mroeschke
approved these changes
May 7, 2026
Member
|
Thanks @jbrockmendel |
hamdanal
pushed a commit
to hamdanal/pandas
that referenced
this pull request
Jun 27, 2026
…vGH-55932) (pandas-dev#65422) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GH-55932 reports that the
foldargument was ignored whentzwas passed as a plain string (e.g.tz=\"US/Pacific\"), whiledateutil.tz.gettz(...)andzoneinfo.ZoneInfo(...)worked. The string was resolving to apytzzone, andpytz.localizeignoresfold, so anAmbiguousTimeErrorwas raised.This was fixed as a side effect of GH-59089 (making pytz an optional dependency):
maybe_get_tznow resolves a plain string tozoneinfo.ZoneInfo, which honors PEP 495fold. This PR just adds a regression test to lock that behavior in — covering both reports in the issue thread (theyear=/month=/...keyword form and the naive-datetime form).Test plan
pytest pandas/tests/scalar/timestamp/test_constructors.py -k fold