Add signal handling integration for site cleanup#89
Open
namespacebrian wants to merge 4 commits intomainfrom
Open
Add signal handling integration for site cleanup#89namespacebrian wants to merge 4 commits intomainfrom
namespacebrian wants to merge 4 commits intomainfrom
Conversation
- Register cleanup handler with Terminus core when site is created - Fix broken cleanup() method call to use cleanupPantheonSite() - Add debug logging for cleanup handler registration and execution - Ensure sites are properly cleaned up when interrupted by SIGINT/SIGTERM Depends on: pantheon-systems/terminus#2731 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Check if getInstance() and registerCleanupHandler() methods exist before using - Gracefully handle cases where Terminus core doesn't have signal handling support - Change error to debug log when signal handling is not available for better CI compatibility 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cleanup()method call to usecleanupPantheonSite()Dependencies
The terminus-core PR adds the signal handling infrastructure that this plugin integrates with. Without that PR, the
registerCleanupHandler()method andgetInstance()static method won't be available.How it works
cleanupPantheonSite()to delete the partially created site and clean up VCS recordsTest plan
site:createand press Ctrl+C during creation