[SITE-4575] Update SimpleSAMLphp security requirements to 2.3.7.#402
Merged
[SITE-4575] Update SimpleSAMLphp security requirements to 2.3.7.#402
Conversation
Composer Changes
|
possible fix for i18n error
jazzsequence
commented
May 28, 2025
Comment on lines
+7
to
+12
| # PHPUnit Helpers | ||
| bin/helpers.sh | ||
| bin/install-wp-tests.sh | ||
| bin/install-local-tests.sh | ||
| bin/phpunit-test.sh | ||
| .phpunit* |
Contributor
Author
There was a problem hiding this comment.
These ignores come from adding wpunit-helpers as a dependency.
jazzsequence
commented
May 29, 2025
|
Hi from your friendly robot! 🤖 I fixed PHPCS issues with |
pwtyler
approved these changes
Jun 6, 2025
This was referenced Jun 6, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the SimpleSAMLphp security requirements to recommend version 2.3.7 as the minimum secure version, while maintaining 2.0.0 as the critical security threshold for CVE-2023-26881 (GHSA-46r4-f8gj-xg56).
Changes
min_simplesamlphp_versionset to '2.3.7'pantheon-systems/wpunit-helperspackage for WP Unit Tests (rather than copy pasta method)pantheon-systems/pantheon-wordpress-upstream-teststo latestFilters added
wp_saml_auth_simplesamlphp_path_array- allows users to define/change the path to their installation of SimpleSAMLphp.wp_saml_auth_ssp_autoloader- allows users to define a path to the SimpleSAMLphp autoloader file (if different from the default)Security Context
Testing
(reopened from #401)