Fix nodes disappearing after closing a node with an ancestor sibling#103
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where nodes were disappearing after closing a node with an ancestor sibling by improving the sibling-finding logic in the TreeState.close method. The fix introduces a more robust approach that traverses up the parent chain to find the next appropriate sibling node.
- Replaced inline sibling-finding logic with a dedicated helper function
findNextSibling - Updated test data to use array values instead of primitive values in the object_array structure
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| extension/src/viewer/components/TreeViewer/Tree/TreeState.ts | Added findNextSibling helper function and refactored the close method to use it for more robust sibling detection |
| samples/test.json | Updated test data structure to use arrays as values in object_array entries |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the logic in the
TreeState.closemethod to use a new helper function,findNextSibling, for determining the next node after closing. This makes the sibling-finding logic more robust by walking up the parent chain until a sibling is found, rather than just checking immediate siblings or parent siblings.