Expose state in URL#112
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates project dependencies and refactors the application state management to add URL fragment state persistence. The main change splits the ApplicationState.ts file into a modular structure and introduces URL hash-based state serialization for search and JQ filter parameters.
- Dependency updates across multiple packages (esbuild, eslint, tailwindcss, vite, and related tooling)
- Refactored application state management into separate modules with URL fragment state support
- Added serialization/deserialization logic for persisting state in URL hash
- Minor code quality improvements (using
window.locationinstead oflocation)
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| extension/yarn.lock | Updated numerous dependencies including @emnapi, @esbuild, @eslint, @rollup, @tailwindcss, @types, and build tools to their latest versions |
| extension/package.json | Bumped versions for dev dependencies (eslint, tailwindcss, typescript-eslint, vite) and react-window |
| extension/src/viewer/state/ApplicationState/index.ts | New barrel export file for the ApplicationState module |
| extension/src/viewer/state/ApplicationState/URLFragmentState.ts | New file implementing URL hash serialization/deserialization for application state with type-safe serializers |
| extension/src/viewer/state/ApplicationState/ApplicationState.ts | Refactored from parent directory with added URL fragment state integration for persisting state in URL |
| extension/src/viewer/state/ApplicationState.ts | Removed - functionality moved to modular structure |
| extension/src/options/components/EnumSelect.tsx | Extracted enum type definitions to global scope (StringEnumType, ValueOf) |
| extension/src/global.d.ts | Added global type definitions for StringEnumType and ValueOf to be reused across the codebase |
| extension/src/content/Activator.ts | Changed location to window.location for better clarity and explicitness |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 8 out of 10 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serialize user's search/filter in the URL so that it can be easily shared and/or bookmarked