fix: remove redundant header insertion in extend_blocks and tests#19534
Merged
shekhirin merged 4 commits intoparadigmxyz:mainfrom Nov 6, 2025
Merged
Conversation
phrwlk
requested review from
Rjected,
fgimenez,
joshieDo,
mattsse,
mediocregopher,
rakita,
shekhirin and
yongkangc
as code owners
yongkangc
pushed a commit
that referenced
this pull request
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mock provider’s extend_blocks() called add_header() and then add_block(), but add_block() already inserts the header. This resulted in redundant header insertions (double locking and duplicate HashMap inserts). In tests, persist_blocks() additionally called extend_headers(), effectively causing triple insertion.
Changes:
This keeps header insertion centralized in add_block(), aligns extend_* helper semantics with others, reduces unnecessary work, and preserves expected ordering.