Skip to content

fix: short-circuit in reveal_account_v2_proof_nodes on empty nodes#21701

Merged
mediocregopher merged 3 commits intomainfrom
klkvr/fix-reveals
Feb 2, 2026
Merged

fix: short-circuit in reveal_account_v2_proof_nodes on empty nodes#21701
mediocregopher merged 3 commits intomainfrom
klkvr/fix-reveals

Conversation

@klkvr
Copy link
Copy Markdown
Member

@klkvr klkvr commented Feb 2, 2026

Right now if reveal_account_v2_proof_nodes will receive an empty vec of nodes before the root node was revealed, it will always fail in else branch here

let trie = if let Some(root_node) = root_node {
trace!(target: "trie::sparse", ?root_node, "Revealing root account node from V2 proof");
self.state.reveal_root(root_node.node, root_node.masks, self.retain_updates)?
} else {
self.state.as_revealed_mut().ok_or(SparseTrieErrorKind::Blind)?
};

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Feb 2, 2026
@mediocregopher mediocregopher added this pull request to the merge queue Feb 2, 2026
Merged via the queue into main with commit 4280ccf Feb 2, 2026
47 checks passed
@mediocregopher mediocregopher deleted the klkvr/fix-reveals branch February 2, 2026 12:28
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants