fix: short-circuit in reveal_account_v2_proof_nodes on empty nodes#21701
Merged
mediocregopher merged 3 commits intomainfrom Feb 2, 2026
Merged
fix: short-circuit in reveal_account_v2_proof_nodes on empty nodes#21701mediocregopher merged 3 commits intomainfrom
mediocregopher merged 3 commits intomainfrom
Conversation
mediocregopher
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now if
reveal_account_v2_proof_nodeswill receive an empty vec of nodes before the root node was revealed, it will always fail in else branch herereth/crates/trie/sparse/src/state.rs
Lines 496 to 501 in ecf3fbe