Skip to content

fix: overlay preparation on tokio#22492

Merged
klkvr merged 2 commits intomainfrom
klkvr/spawn-blocking-overlay
Feb 23, 2026
Merged

fix: overlay preparation on tokio#22492
klkvr merged 2 commits intomainfrom
klkvr/spawn-blocking-overlay

Conversation

@klkvr
Copy link
Copy Markdown
Member

@klkvr klkvr commented Feb 23, 2026

this might block and thus should not be spawned on rayon

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 23, 2026

⚠️ Changelog not found.

A changelog entry is required before merging. We've generated a suggested changelog based on your changes:

Preview
---
reth-chain-state: patch
reth-engine-tree: patch
---

Added a debug assertion in `wait_cloned` to prevent it from being called on a rayon worker thread. Fixed overlay preparation in the engine tree to use `tokio::task::spawn_blocking` instead of `rayon::spawn` to avoid blocking rayon threads.

Add changelog to commit this to your branch.

@klkvr klkvr requested a review from fgimenez as a code owner February 23, 2026 14:44
@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Feb 23, 2026
@klkvr klkvr added this pull request to the merge queue Feb 23, 2026
Merged via the queue into main with commit ca47a7e Feb 23, 2026
38 checks passed
@klkvr klkvr deleted the klkvr/spawn-blocking-overlay branch February 23, 2026 15:47
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Feb 23, 2026
emmajam pushed a commit that referenced this pull request Feb 23, 2026
emmajam pushed a commit that referenced this pull request Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants