Conversation
mattsse
approved these changes
Oct 13, 2022
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
no authors in the original: https://docs.rs/crate/fastrlp/0.1.2/source/Cargo.toml.orig
should we make a note in the readme?
Collaborator
Author
|
Will add the note |
gakonst
approved these changes
Oct 13, 2022
Member
gakonst
left a comment
gakonst
left a comment
There was a problem hiding this comment.
Sounds good. We'll need to derive this in ethers core types though? If we're doing this, maybe we should just sprint on ruint usage over Primitive Types & Ethers Core? And get this fastrlp there?
onbjerg
added
C-enhancement
greged93
added a commit
to greged93/reth
that referenced
this pull request
Dec 11, 2024
* add l1_fee field to `Receipt` Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * scroll consensus Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * feat: scroll execution strategy Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * feat: expose `verify_receipts` from reth-ethereum-consensus Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * feat: add `reth-scroll-evm` crate to avoid cyclic dep Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * improve curie fork application + test Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * integrate l1 fee Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * add `ScrollEvmConfig` Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * add tests for `ScrollEvmConfig` Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * add tests for `ScrollExecutionStrategy` Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * add l1 message test for `ScrollExecutionStrategy` Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * add legacy tx execution test for `ScrollExecutionStrategy` Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * use revm scroll fork Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * introduce `ScrollExecutionStrategyFactory` Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * feat: patch revm crate to scroll fork Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * fix: lints Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * fix: deny Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * answer comments Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * fill `TxEnv.rlp_bytes` only for !is_l1_message Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * lints Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * switch revm to scroll default branch Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * fix: deny Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * fix: remove alloy-sol-types patch Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * feat: propagate scroll chain spec in execution Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * fix: scroll ci Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * chore: bump `trust-dns-resolver` to 0.25 alpha4 to fix deny Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * fix: propagate serde feature Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * fix: docs Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * answer comments Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * lint Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * answer comments Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> --------- Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
shemnon
added a commit
to shemnon/reth
that referenced
this pull request
Jan 20, 2026
- remove tectonic-kurtosis - update CLAUDE.md - update TECTONIC.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including apache licenced fastrlp from here: https://docs.rs/fastrlp/0.1.2/fastrlp/index.html
Bloom filters need to be enabled behind
ethereum-types, they are not commented out.