Refactor typechecker to hide type substitution#361
Merged
supercooldave merged 1 commit intoApr 7, 2016
Conversation
This commit refactors the way type substitution is handled so that it is
completely encapsulated in the lookup rules of the environment. As an
example, take the following class
```
passive class Foo<t>
f : t
class Main
def main() : void {
let x = new Foo<int>;
x.f = 42;
}
```
In order to ensure that the assignment on the last line is valid, we
need to build a set of bindings that maps `t` to `int`, so that the
field `f : t` looks like `f : int` when we do the lookup. Instead of
cluttering the typechecker with this sort of thing, this translation is
now done implicitly on field lookup.
|
Argh. I'll never the get type synonyms done if you keep changing things!! |
Contributor
Author
|
@supercooldave: I'm fine with postponing this merge until the type synonyms are done, and then the problem is mine to fix instead! My guess is that if anything this refactoring should make things simpler. |
|
@EliasC I can see whether this causes any chaos – I was mainly moaning because I'd just managed to finish processing the last batch of changes to get type synonyms up to date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the way type substitution is handled so that it is
completely encapsulated in the lookup rules of the environment. As an
example, take the following class
In order to ensure that the assignment on the last line is valid, we
need to build a set of bindings that maps
ttoint, so that thefield
f : tlooks likef : intwhen we do the lookup. Instead ofcluttering the typechecker with this sort of thing, this translation is
now done implicitly on field lookup.
Since it's refactoring, I have included no new tests (or documentation).