fix: Hard-coding of react-native path does not work for workspace builds#1930
Merged
mtrezza merged 2 commits intoparse-community:alphafrom Jun 8, 2023
Merged
fix: Hard-coding of react-native path does not work for workspace builds#1930mtrezza merged 2 commits intoparse-community:alphafrom
react-native path does not work for workspace builds#1930mtrezza merged 2 commits intoparse-community:alphafrom
Conversation
This hard-coding of `../../../react-native/...` prevents the package from working in workspace builds. Signed-off-by: swittk <switt1995@gmail.com>
Thanks for opening this pull request!
|
swittk
changed the title
react-native path in react-native buildsreact-native path in react-native builds
swittk
changed the title
react-native path in react-native buildsreact-native path in react-native builds
swittk
changed the title
react-native path in react-native buildsreact-native path in react-native builds
dplewis
approved these changes
Jun 8, 2023
Member
dplewis
left a comment
dplewis
left a comment
There was a problem hiding this comment.
LGTM! I don't know why relative path is there.
mtrezza
changed the title
react-native path in react-native buildsreact-native path does not work for workspace builds
parseplatformorg
pushed a commit
that referenced
this pull request
Jun 8, 2023
# [4.2.0-alpha.2](4.2.0-alpha.1...4.2.0-alpha.2) (2023-06-08) ### Bug Fixes * Hard-coding of `react-native` path does not work for workspace builds ([#1930](#1930)) ([8222f3c](8222f3c))
Contributor
|
🎉 This change has been released in version 4.2.0-alpha.2 |
4 tasks
parseplatformorg
pushed a commit
that referenced
this pull request
Sep 16, 2023
# [4.3.0-beta.1](4.2.0...4.3.0-beta.1) (2023-09-16) ### Bug Fixes * `ParseUser.linkWith` doesn't remove anonymous auth data ([#2007](#2007)) ([7e2585c](7e2585c)) * Hard-coding of `react-native` path does not work for workspace builds ([#1930](#1930)) ([8222f3c](8222f3c)) ### Features * Add Bytes type to `Parse.Schema` ([#2001](#2001)) ([343d0d7](343d0d7)) * Add Cloud Code context accessibility to `ParseUser.logIn` ([#2010](#2010)) ([2446007](2446007)) * Add support for custom EventEmitter ([#1999](#1999)) ([ca568a6](ca568a6)) * Add support for excluding keys in `ParseQuery.findAll` ([#2000](#2000)) ([012ba4c](012ba4c)) * Add support to invoke a Cloud Function with a custom `installationId` via `Parse.Cloud.run` ([#1939](#1939)) ([eb70b93](eb70b93)) * Allow overriding `Parse.Error` message with custom message via new Core Manager option `PARSE_ERRORS` ([#2014](#2014)) ([be0c8a6](be0c8a6)) * Login with username, password and additional authentication data via `ParseUser.logInWithAdditionalAuth` ([#1955](#1955)) ([2bad411](2bad411))
Contributor
|
🎉 This change has been released in version 4.3.0-beta.1 |
parseplatformorg
pushed a commit
that referenced
this pull request
Sep 26, 2023
# [4.3.0-alpha.1](4.2.0...4.3.0-alpha.1) (2023-09-26) ### Bug Fixes * `ParseUser.linkWith` doesn't remove anonymous auth data ([#2007](#2007)) ([7e2585c](7e2585c)) * Hard-coding of `react-native` path does not work for workspace builds ([#1930](#1930)) ([8222f3c](8222f3c)) ### Features * Add Bytes type to `Parse.Schema` ([#2001](#2001)) ([343d0d7](343d0d7)) * Add Cloud Code context accessibility to `ParseUser.logIn` ([#2010](#2010)) ([2446007](2446007)) * Add support for custom EventEmitter ([#1999](#1999)) ([ca568a6](ca568a6)) * Add support for excluding keys in `ParseQuery.findAll` ([#2000](#2000)) ([012ba4c](012ba4c)) * Add support to invoke a Cloud Function with a custom `installationId` via `Parse.Cloud.run` ([#1939](#1939)) ([eb70b93](eb70b93)) * Allow overriding `Parse.Error` message with custom message via new Core Manager option `PARSE_ERRORS` ([#2014](#2014)) ([be0c8a6](be0c8a6)) * Login with username, password and additional authentication data via `ParseUser.logInWithAdditionalAuth` ([#1955](#1955)) ([2bad411](2bad411))
Contributor
|
🎉 This change has been released in version 4.3.0-alpha.1 |
parseplatformorg
pushed a commit
that referenced
this pull request
Nov 16, 2023
# [4.3.0](4.2.0...4.3.0) (2023-11-16) ### Bug Fixes * `ParseUser.linkWith` doesn't remove anonymous auth data ([#2007](#2007)) ([7e2585c](7e2585c)) * Hard-coding of `react-native` path does not work for workspace builds ([#1930](#1930)) ([8222f3c](8222f3c)) ### Features * Add Bytes type to `Parse.Schema` ([#2001](#2001)) ([343d0d7](343d0d7)) * Add Cloud Code context accessibility to `ParseUser.logIn` ([#2010](#2010)) ([2446007](2446007)) * Add support for custom EventEmitter ([#1999](#1999)) ([ca568a6](ca568a6)) * Add support for excluding keys in `ParseQuery.findAll` ([#2000](#2000)) ([012ba4c](012ba4c)) * Add support to invoke a Cloud Function with a custom `installationId` via `Parse.Cloud.run` ([#1939](#1939)) ([eb70b93](eb70b93)) * Allow overriding `Parse.Error` message with custom message via new Core Manager option `PARSE_ERRORS` ([#2014](#2014)) ([be0c8a6](be0c8a6)) * Login with username, password and additional authentication data via `ParseUser.logInWithAdditionalAuth` ([#1955](#1955)) ([2bad411](2bad411))
Contributor
|
🎉 This change has been released in version 4.3.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
This hard-coding of
../../../react-native/...prevents the package from working in workspace builds.Closes: None. But the build fails when you use
parse/react-nativewhen using PNPM workspaces.Approach
Change import path from the legacy, hard-coded
require('../../../react-native/...')torequire('react-native/...')Tasks