`validateEmailConfiguration` should be called when sending reset password email

[natanrolnik]

• You've met the prerequisites.
• You're running the latest version of Parse Server.
• You've searched through existing issues. Chances are that your issue has been reported or resolved before.

Environment Setup

Parse Server 2.2.7 on Heroku

Steps to reproduce

• Configure an Email Adapter in index.js
• Don't configure app name and/or public server URL
• Request a reset password email via requestPasswordReset

Result

Users will receive an email with title "Password reset for undefined", and body:

"You requested to reset your password for undefined. Click here to reset it: undefined/apps/....."

Expected Result

validateEmailConfiguration or some variation of it should be called before sending reset password emails, to make sure that both app name and public server url were set correctly.

[drew-gross]

Yep that definitely should be called. Not sure when it stopped being called.

[drew-gross]

Actually this seems to be a different issue. I made a regression test in #1650 and it passes.

[natanrolnik]

The regression test you wrote doesn't really test what I mentioned here. I'll comment on the PR.
I think it's still a bug.

[damtsnkff]

@natanrolnik Did you solve it ? I'm facing the exact same problem. I tried with parse-server: ~2.2.7 and ~2.2.2

[damtsnkff]

@natanrolnik @drew-gross Ok that was a stupid mistake. I forgot the publicServerURL... and I was checking the wrong index.js when debugging. Fixed for me.