Merged
Conversation
Contributor
|
I have no idea about docker, so I really don't feel qualified to review this. @davimacedo could you take a look? |
Member
Author
|
@TomWFox If you look at the file there are 2 build phases. The first build phase adds git, I just copied it down to the release build. |
Codecov Report
@@ Coverage Diff @@
## master #5861 +/- ##
=========================================
- Coverage 93.68% 93.1% -0.59%
=========================================
Files 150 150
Lines 10616 10616
=========================================
- Hits 9946 9884 -62
- Misses 670 732 +62
Continue to review full report at Codecov.
|
Contributor
|
Ok, makes sense. |
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The push adapter now uses a node-apn fork. This PR adds git to the build to pull the fork down.
I'm not a docker expert. Any feedback would be great.