Skip to content

fix rollout params for when #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hugomontero merged 2 commits into from
Jan 22, 2026
Merged

fix rollout params for when #893

hugomontero merged 2 commits into from
Jan 22, 2026

Conversation

@hugomontero
Copy link
Contributor

@hugomontero hugomontero commented Jan 22, 2026 •
edited
Loading

Description

Fix rollout valid values for when param.

How to Test

  • Attempt to make a rollout: npm start -- env-vars rollout --sandbox

Related Issues / Discussions

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA
  • Problem and solution clearly stated
  • Tests have been provided
  • Docs have been updated
  • CI is passing

sergeuz
sergeuz approved these changes Jan 22, 2026
View reviewed changes
Copy link
Member

@sergeuz sergeuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me now, thanks!

@hugomontero hugomontero merged commit db19ecc into master Jan 22, 2026
8 of 10 checks passed
@hugomontero hugomontero deleted the bug/fix-rollout-params branch January 22, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergeuz sergeuz sergeuz approved these changes

@monkbroc monkbroc Awaiting requested review from monkbroc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hugomontero @sergeuz