Skip to content

[Maintainer] Saved camera views should restore projection and lens, not just position and target #1280

Open

Description

@Aymericr

Follow-up from #1279 (review threads there).

When a project opens on a saved camera view, and when you use the existing "view saved camera" action, only the camera's position and target are applied. The saved projection (perspective vs orthographic) and lens (field of view / zoom) are ignored, so a view saved in orthographic or with a custom lens reopens looking different from how it was saved.

This was left out of #1279 on purpose, because both paths should change together.

Scope

  • Apply the saved projection and lens wherever a saved view is restored: the opening camera in custom-camera-controls.tsx and the view-saved-camera action.
  • Keep older saved views without these fields working (fall back to the current behavior).
  • Add a test for a perspective view and an orthographic view round-tripping.

Done when a view saved in orthographic with a custom zoom reopens identically, on project open and from the views bar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions