Skip to content

viewer: saved capture point clouds draw as the live stream does - #1294

Merged
wass08 merged 1 commit into
mainfrom
fix/point-cloud-no-bloom
Nov 18, 2026
Merged

wass08 merged 1 commit into
mainfrom
fix/point-cloud-no-bloom

Conversation

@wass08

@wass08 wass08 commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

What does this PR do?

Saved capture point clouds now look like the live stream of the same scan. A saved cloud was drawn in the scene pass, so the daylight exposure, grade and bloom turned light-coloured points into a warm, glowing haze; the live cloud is drawn on the overlay layer and keeps its flat colours. CapturePointCloudLayer now draws its discs on OVERLAY_LAYER too.

Trade-off: like the live cloud, the saved cloud is no longer hidden by scene geometry, so it shows through walls built later. It stays a reference layer that can be hidden from the capture's layers.

How to test

  1. Open a project with a saved LiDAR scan whose point cloud layer is on, in the daylight look at high render quality.
  2. The points read in their own colours, as they did while the phone streamed them; before, light points glowed into a cream haze.

Screenshots / screen recording

Not added yet.

Checklist

  • I've tested this locally with bun dev
  • My code follows the existing code style (run bun check to verify)
  • I've updated relevant documentation (if applicable)
  • This PR targets the main branch

🤖 Generated with Claude Code


Note

Low Risk
Single rendering-layer assignment for point disc visuals; no auth, data, or API changes.

Overview
Saved capture point clouds now render on OVERLAY_LAYER (same path as shared PointCloudDataLayer for live, inline, and PLY), so they skip the scene post-process pass—exposure, grade, and bloom—that made light points look like a warm haze.

The trade-off matches the live stream: discs composite on top and are no longer depth-occluded by scene geometry (e.g. they can show through walls), but stay hideable via capture layer controls.

Reviewed by Cursor Bugbot for commit 3858dd2. Bugbot is set up for automated code reviews on this repo. Configure here.

A saved cloud went through the scene's exposure, grade and bloom, which turned light points
into a warm glowing haze, while the same points streamed live (on the overlay) read as flat
colour. The saved cloud's discs are drawn on the overlay layer too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@wass08
wass08 force-pushed the fix/point-cloud-no-bloom branch from a63c522 to 3858dd2 Compare November 18, 2026 16:05
@wass08 wass08 changed the title viewer: capture point clouds stay out of the bloom viewer: saved capture point clouds draw as the live stream does Nov 18, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3858dd2. Configure here.

colors={data.colors}
// As the phone streams it while scanning: flat colours over the image, untouched by the
// scene's exposure, grade and bloom, which turned light points into a warm glowing haze.
layer={OVERLAY_LAYER}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Point clouds vanish from snapshots

Medium Severity

Putting saved clouds on OVERLAY_LAYER also takes them off the scene pass used for thumbnails, viewport screenshots, and sheet captures. Those cameras disable EDITOR_LAYER (the same bit) and the snapshot pipeline has no overlay composite, so a scan that is only a point cloud renders as an empty picture.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 3858dd2. Configure here.

@wass08
wass08 merged commit cf37d32 into main Nov 18, 2026
8 checks passed
@wass08
wass08 deleted the fix/point-cloud-no-bloom branch November 18, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant